Senichi/time dependent speed up - #32
Conversation
…m with dtee, dtei and dtmo in dynamic mode
| else ! separate ion and neutral energy equation | ||
| wrk2 = 1.5_R8*(dv%ni(:,1)-psnl%ni(:,1)) | ||
| & *ts_factor*psnl%ti/dtim*geo%cvVol | ||
| wrk2(mpg%nCi+1:mpg%nCv) = 0.0_R8 |
There was a problem hiding this comment.
Why is wrk2 in the guard cells still zeroed out in this case but not in the others above? I see later it does not matter, but it should be made consistent with the other cases.
| write(hlp_frm,'(a,i3,a,i3,a,i3,a)') '(a1,6x,a4,5x,', | ||
| , nr_tmp*nrg_tmp,'(4x,a8,i2.2),', | ||
| , ns_tmp*nsp_tmp,'(4x,a8,a2),1x,', | ||
| , ns_tmp*nsp_tmp,'(4x,a8,a2),', |
There was a problem hiding this comment.
Can you show me an example of the file before and after this format change?
| @@ -352,7 +364,7 @@ subroutine b2wrsrti(nregionv,switch) | |||
| if (nfl_tmp.gt.0) then | |||
| write(hlp_frm,'(a,i3,a)') '(1p,e16.7,', | |||
| + nr_tmp*nrg_tmp + ns_tmp*nsp_tmp + na_tmp*nrg_tmp*nsp_tmp, | |||
There was a problem hiding this comment.
The e3 part of the format here is so that 10^{-100} will be printed as 1.0E-100 instead of 1.0-100, which can confise some analysis scripts. You should not have removed it.
| @@ -252,13 +253,13 @@ subroutine read_b2mod_numerics_namelist(nCv,ns,nsmin,nsmax,nnreg, | |||
| do ireg = 0, nnreg(0) | |||
| solveet(ireg) = (solveee(ireg).and.solveei(ireg)) | |||
| & .and.solveet(ireg) | |||
There was a problem hiding this comment.
I think you should rephrase the (now) warning messages below to be more informative. If the user is asking for a dynamic simulation with the total momentum and/or energy equations, the message should ask whether this is intentional and under which conditions this can be a good or bad idea.
3 participants
These changes were suggested by Lisa K 'with her outstanding great wisdom'. Briefly speaking, sometimes it is necessary to keep terms like Ted(ne)/d(dt) (which are available only with 'b2mndt_style=2', but simultaneously do not care about true time-dependent mode - e.g. apply the speed-up by increasing dtee, dtei, dtmo in some regions. In such case it is worth to replace error messages with warning ones.
Additionally, for such cases a treatment of terms like Ted(ne)/d(dt) is changed to speed-up the internal energy (or full momentum) even if dtee*rxf .ne. 1.0. Actually, a 'third' option from my User Forum presentation is implemented.