Use positive face-normal projection for fcQgam - #39
Open
jlore wants to merge 2 commits into
Open
Conversation
jlore
marked this pull request as ready for review
August 12, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the fcQgam change from the other bug fixes in #37.
The change uses the magnitude of the face-normal sine projection when forming fcQgam for the two adjacent cell-center-to-face vectors. This avoids a sign-dependent cancellation in the weighted face value while leaving the tangential/cosine component unchanged.
Flagging this for review because it changes the interpretation of the fcQgam normal projection and may affect boundary/gradient behavior on general unstructured grids.