Skip to content

Fix TS2300 duplicate import errors in HoverButtons.tsx blocking CI build #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix TS2300 duplicate import errors in HoverButtons.tsx blocking CI build #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1226333
Initial plan
Copilot Jul 30, 2026
0a8d66a
Fix duplicate imports in HoverButtons.tsx and apply PR #101 changes
Copilot Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend/src/renderer/components/grid/HoverButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
IconTrash,
IconTarget,
} from '@tabler/icons-react';
import { useHover } from '@mantine/hooks';
import { useElementSize, useHover, useMergedRef } from '@mantine/hooks';
import {
Configuration,
CustomizedGridType,
Expand Down Expand Up @@ -55,6 +55,8 @@ export const HoverButtons = React.memo(
}: HoverButtonsProps) => {
const { active, updatedConfiguration } = useIbexStore();
const { hovered, ref: hoverRef } = useHover();
const { ref: sizeRef, width: containerWidth } = useElementSize();
const containerRef = useMergedRef(hoverRef, sizeRef);
const previousValueDisplayErrorBands = useRef<boolean | undefined>(
undefined,
);
Expand Down Expand Up @@ -196,7 +198,7 @@ export const HoverButtons = React.memo(
};

return (
<div ref={hoverRef} className={classes.containerButton}>
<div ref={containerRef} className={classes.containerButton}>
<Group justify="space-between" h={'100%'}>
{is3DView || !data.coordinates.length || shouldDisplayMetadata ? (
<Tabs
Expand All @@ -209,10 +211,10 @@ export const HoverButtons = React.memo(
scrollbarSize={6}
offsetScrollbars
maw={
hoverRef?.current?.offsetWidth
containerWidth
? !data.coordinates.length || shouldDisplayMetadata
? hoverRef.current.offsetWidth - 110
: hoverRef.current.offsetWidth - 230
? containerWidth - 110
: containerWidth - 280
: '100%'
}
>
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/renderer/layout/MainLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ export function MainLayout() {
line: plot?.line || {},
customPreferences: plot?.customPreferences || {},
mode: plot?.mode || 'line',
smoothing: plot?.smoothing,
operations: plot?.operations,
};
}),
}),
Expand Down
22 changes: 22 additions & 0 deletions frontend/src/renderer/pages/visualization/DataplotCustomization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import {
CustomizeDataRange,
CustomizeSynchronization,
CustomizeInterpolation,
CustomizeSmoothing,
CustomizeUnaryOperations,
CustomizeGeometry,
} from './customizableElements';
import { IconGeometry, IconLink } from '@tabler/icons-react';
Expand Down Expand Up @@ -481,6 +483,26 @@ const Customization = ({
/>
),
},
{
value: 'Data smoothing',
component: (
<CustomizeSmoothing
customizedDataGrid={customizedDataGrid}
selectedPlot={selectedPlot}
setCustomizedDataGrid={setCustomizedDataGrid}
/>
),
},
{
value: 'Unary operations',
component: (
<CustomizeUnaryOperations
customizedDataGrid={customizedDataGrid}
selectedPlot={selectedPlot}
setCustomizedDataGrid={setCustomizedDataGrid}
/>
),
},
];

const items = (
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/renderer/pages/visualization/customizableElements/CustomizeDownsampling.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
getUrisToInterpolate,
getVectorData,
normalizeIndices,
reapplyAxisOrder,
} from '../../../utils';
import { showNotification } from '@mantine/notifications';
import { Button, Group, NumberInput, Select, Stack } from '@mantine/core';
Expand Down Expand Up @@ -118,6 +119,13 @@ export const CustomizeDownsampling = ({
plotIndex++;
}

// Re-apply axis transposition: the back-end returns data in default axis
// order, so restore the user's transposition after the fetch
const wantedAxeIndexOrder = customizedDataGrid.coordinates.map(
(coord) => coord.axeIndex,
);
await reapplyAxisOrder(updatedDataPlot, wantedAxeIndexOrder);

// Save new configuration with downsampled data
setCustomizedDataGrid({
...customizedDataGrid,
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/renderer/pages/visualization/customizableElements/CustomizeInterpolation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
normalizeIndices,
getInterpolationMethods,
getUrisToInterpolate,
reapplyAxisOrder,
} from '../../../utils';
import { showNotification } from '@mantine/notifications';
import { Group, Loader, Select, Stack } from '@mantine/core';
Expand Down Expand Up @@ -118,6 +119,13 @@ export const CustomizeInterpolation = ({
plotIndex++;
}

// Re-apply axis transposition: the back-end returns data in default axis
// order, so restore the user's transposition after the fetch
const wantedAxeIndexOrder = customizedDataGrid.coordinates.map(
(coord) => coord.axeIndex,
);
await reapplyAxisOrder(updatedDataPlot, wantedAxeIndexOrder);

// Save new configuration with interpolated data
setCustomizedDataGrid({
...customizedDataGrid,
Expand Down
Loading
Loading