Skip to content

Exclude dynamic_aos geometry nodes - #119

Merged
olivhoenen merged 2 commits into
iterorganization:developfrom
jwasikpsnc:bugfix/106-restrict-dynamic-geometries
Aug 6, 2026
Merged

Exclude dynamic_aos geometry nodes#119
olivhoenen merged 2 commits into
iterorganization:developfrom
jwasikpsnc:bugfix/106-restrict-dynamic-geometries

Conversation

@jwasikpsnc

@jwasikpsnc jwasikpsnc commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Fix #106

@olivhoenen

Copy link
Copy Markdown
Contributor

Fix for #106

Thanks @jwasikpsnc
As a side note, please do not add "for" between the fix keyword and the ref to the issue, so we get link to issue (cf. https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue)

@olivhoenen olivhoenen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current implementation does not fix the issue, equilibrium/time_slice/boundary/outline is still presented (you can use URIs from https://github.com/user-attachments/files/30748723/aug-geomIbexState.json)
Image

Comment thread backend/ibex/data_source/imas_python_source.py
Comment thread backend/ibex/data_source/imas_python_source.py Outdated

@olivhoenen olivhoenen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@olivhoenen
olivhoenen merged commit 17cbcec into iterorganization:develop Aug 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict exposed geometry to be constant/static structures

2 participants