fix: GGD ionization_potential is an energy (eV), not a charge (e) - #280
Open
Simon-McIntosh wants to merge 1 commit into
Open
fix: GGD ionization_potential is an energy (eV), not a charge (e)#280Simon-McIntosh wants to merge 1 commit into
Simon-McIntosh wants to merge 1 commit into
Conversation
…arge (e) The generic-grid copy of ion/state/ionization_potential declares units='e' (elementary charge) while the four other declarations of the same quantity — core_profiles/profiles_1d, and the profiles_1d/profiles_2d copies in dd_support.xsd — all declare 'eV'. An ionisation potential is an energy, so the GGD declaration is dimensionally wrong ([current].[time] instead of [mass].[length]^2/[time]^2) and contradicts its own siblings. The element sits directly beneath z_min/z_max/z_average/z_square_average, which are charge numbers legitimately annotated 'e'; the 'e' appears to have been carried down to the adjacent element. Affects 6 paths in DD 4.1.1 (edge_profiles and plasma_profiles GGD, each as the struct-array plus its values and coefficients children). Metadata-only correction: the stored values were always energies, only the declared unit was wrong.
Simon-McIntosh
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
July 27, 2026 10:20
DavidPCoster
approved these changes
Jul 27, 2026
simpla-fusion
approved these changes
Jul 28, 2026
SimonPinches
approved these changes
Jul 28, 2026
medvedevsyu
approved these changes
Jul 29, 2026
imbeauf
approved these changes
Jul 30, 2026
qsthayashi
approved these changes
Jul 31, 2026
aksinghh
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277.
ion/state/ionization_potentialis declared five times in DD 4.1.1. Four declareeV; the GGD copy indd_support.xsddeclarese(elementary charge). An ionisation potential is an energy, so the GGD declaration is dimensionally wrong —[current]·[time]instead of[mass]·[length]²/[time]²— and contradicts its own siblings.The element sits directly beneath
z_min/z_max/z_average/z_square_average, which are charge numbers legitimately annotatede; theeappears to have been carried down to the adjacent element.Change
One line,
schemas/utilities/dd_support.xsd:11990:Verification
eV(dd_core_profiles.xsd:424,dd_support.xsd:3372,:9777,:11209,:11986).z_min,z_max,z_average,z_square_average) are unchanged and still declaree.dd_support.xsdparses as well-formed XML.edge_profilesandplasma_profilesGGD, each as the struct-array plus itsvaluesandcoefficientschildren.Metadata-only correction — the stored values were always energies; only the declared unit was wrong.
📚 Documentation preview 📚: https://imas-data-dictionary--280.org.readthedocs.build/en/280/