Equilibrium DD3to4 conversion for boundary_separatrix - #62
Merged
olivhoenen merged 6 commits intoSep 29, 2025
Merged
Conversation
- Handle multiple x-points in boundary_[secondary_]separatrix - Determine if O-point at magnetic axis is a local minimum or maximum of the psi map
maarten-ic
force-pushed
the
feature/dd3to4-boundary-conversion
branch
from
August 28, 2025 12:36
289b8a5 to
83ff945
Compare
Collaborator
|
@maarten-ic this one seems ready now to proceed further, I guess some conflict resolving/rebasing together with the added info in the documentation is all what's missing. |
…thon into feature/dd3to4-boundary-conversion
maarten-ic
marked this pull request as ready for review
September 29, 2025 12:24
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
September 29, 2025 12:24
olivhoenen
approved these changes
Sep 29, 2025
olivhoenen
left a comment
olivhoenen
left a comment
Collaborator
There was a problem hiding this comment.
Works as expected and shown in the issue #60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
TODO: