Skip to content

Use of Facade in BaseViewFactory  #2

Description

@RemiCollin

The use of Facade in a package isn't generally regarded as a good pratice, as a user could use custom names for his class aliases in config/app.php.
A better way would be to use Illuminate\Contracts in place, and use a service provider to inject the dependency in class __construct() method.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions