pgconn: use fresh context for fallback connection in connectPreferred#2554
Merged
jackc merged 1 commit intoMay 16, 2026
Merged
Conversation
When ConnectTimeout is set, connectPreferred creates a per-host timeout context derived from octx for each host. After the loop, ctx holds whatever context was used for the last attempt, which may have already expired. The fallback connection (for prefer-standby/prefer-primary) was using that stale ctx, so it would fail immediately with a deadline exceeded error even though the original context still had time left. Fix this by creating a fresh timeout context from octx for the fallback, same as we do for each host in the loop. Fixes jackc#2172
Owner
|
LGTM |
c-tonneslan
added a commit
to c-tonneslan/portfolio
that referenced
this pull request
May 16, 2026
Add an optional status="merged" field on PR entries and render a small green "merged" badge next to the title in ContribCard. Mark the three PRs that have actually been merged so far (jackc/pgx#2554, nats-io/nats.go#2076, urfave/cli#2328). Drop the two closed-without-merge PRs that were still listed (go-chi/chi#1093, tailscale/tailscale#19689). Closed PRs aren't something I want to show off, so the data file just never carries them, no need for a "closed" status. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ConnectTimeoutis set,connectPreferredcreates a per-host timeout context (derived fromoctx) for each host in the loop. After the loop finishes,ctxholds whatever context was used for the last host, which may have already expired by the time we get to the fallback.The fallback path (for
prefer-standby/prefer-primary) was passing that stalectxtoconnectOne, so it would immediately get a deadline exceeded error even though the caller's original context still had time left.The fix creates a fresh
ConnectTimeout-bounded context fromoctxfor the fallback, same pattern as the loop uses for each host.Fixes #2172