fix(pgxpool): enforce MaxConnLifetime at Acquire time#2562
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Looks like a duplicate of #2561 😇 |
Author
|
Ack, closing in favor of #2561. Thanks for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaxConnLifetime was only checked by the background health check, which inspects idle connections. On a hot pool a connection is constantly acquired and returned, so it is rarely idle when the check fires and can live well past MaxConnLifetime. This adds an isExpired check in the Acquire loop so the limit holds regardless of pool utilization.
Closes #2560