Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A command alias could silently overwrite an already registered command with the same site/name. That made adapter and plugin load order change which implementation ran for an established command.
The registry now ignores only the conflicting alias while continuing to register any remaining unique aliases. A regression test proves that the original command remains routable and a unique alias still works.
Related issue: None.
Type of Change
Checklist
Screenshots / Output
Note: the full npm test run was also attempted. Its unrelated plugin/download/adapter failures require local listener or download capabilities unavailable in this environment; the focused registry suite and typecheck pass.