fix(1point3acres): resolve identity on the redesigned UI - #2529
Open
Benjamin-eecs wants to merge 1 commit into
Open
Benjamin-eecs wants to merge 1 commit into
Benjamin-eecs wants to merge 1 commit into
Conversation
Benjamin-eecs
force-pushed
the
fix/1p3a-identity-probe-new-ui
branch
2 times, most recently
from
September 20, 2026 06:46
42d9cbb to
606fe7f
Compare
Bare /bbs/ now redirects logged-in users to the /home SPA, which carries no Discuz identity markup (jackwener#2528).
Benjamin-eecs
force-pushed
the
fix/1p3a-identity-probe-new-ui
branch
from
September 20, 2026 06:52
606fe7f to
bd21433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1point3acres whoamifailed withAUTH_REQUIREDon valid sessions. Bare/bbs/redirects logged-in users to the redesigned/homeSPA, which carries none of the Discuz identity markup the probe expects, so the probe fell through to its anonymous branch.The probe now reads
/bbs/home.php?mod=space, a Discuz-native page that still serves the user panel.?forum_ui=classicalso works but writes the reader's saved UI preference, so it is deliberately not used. If a run still lands on a signed-in surface without that panel, the uid is decoded from the Discuz avatar path, accepted only when the image is served fromavatar.1p3a.comand every avatar on the page decodes to the same uid, so neither a foreign host nor a feed of other members can be reported as the viewer. That fallback sits below the anonymity check, so a page with no signed-in surface staysauth. An identity the probe cannot resolve is ashapefailure rather thanauth, since it runs only after the*_authcookie check passes.Related issue: Closes #2528
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output
Before, on a session whose
auth statusreportslogged_in: true:After, same session:
The avatar fallback was checked separately against the live
/homeSPA, which renders two avatars both decoding to the viewer's uid; it yields the uid with an empty username, since that UI shows no name.clis/1point3acressuite 13 / 13, eight added here. Every behaviour is mutation-checked: switching the navigation back to?forum_ui=classic, relaxing the avatar host check to a substring match, taking the first avatar instead of requiring agreement, moving the fallback above the anonymity check, keeping the placeholder uid, or mapping ashaperesult back toAuthRequiredErroreach fails a test. Typecheck, both lint gates and doc coverage pass.