Skip to content

ci: pin e2e control image to 1.10.7, generalize ALREADY_FIXED pattern (#24) - #68

Merged
jacobyoby merged 1 commit into
jacob/maintainedfrom
feature/e2e-pin-image-24
Sep 10, 2026
Merged

ci: pin e2e control image to 1.10.7, generalize ALREADY_FIXED pattern (#24)#68
jacobyoby merged 1 commit into
jacob/maintainedfrom
feature/e2e-pin-image-24

Conversation

@jacobyoby

Copy link
Copy Markdown
Owner

The e2e harness broke when upstream 1.10.8 shipped a11y fixes that the fork also carries.

Docker image pinned:

  • UPSTREAM_IMAGE env var set to jhpyle/docassemble:1.10.7
  • Comment notes bumping is part of every upstream rebase
  • All :latest references replaced

ALREADY_FIXED generalized to all 9 control steps:

  • Issues 15, 18, 19, 343, 845, 968, 980, 981, NFC
  • When upstream already carries a fix: logs notice and continues instead of failing
  • Setup steps for dependent controls remain unconditional

Closes #24.

Generated with Qwen Code

…l control steps

- Add UPSTREAM_IMAGE env var pinned to jhpyle/docassemble:1.10.7
- Replace jhpyle/docassemble:latest with ${UPSTREAM_IMAGE}
- Wrap all control steps (issues 15, 18, 19, 343, 845, 968, 980, NFC) with ALREADY_FIXED pattern
- Control steps now log 'ALREADY FIXED upstream' and continue instead of failing when fixes are already in the pinned image
- Fixes #24
@jacobyoby
jacobyoby merged commit 1f22ae4 into jacob/maintained Sep 10, 2026
3 checks passed
@jacobyoby
jacobyoby deleted the feature/e2e-pin-image-24 branch September 10, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e harness is red since upstream 1.10.8: the a11y control pins jhpyle/docassemble:latest, which moved

1 participant