Test - #2
Open
jadestrong wants to merge 15 commits into
Open
Conversation
added 15 commits
April 23, 2026 08:26
This commit renames the core ACP proxy implementation file and updates all internal references to use the simpler "acp" naming convention. The bundled implementation now provides the same interface as the original acp.el package while routing through the Rust proxy server. Key changes: - Renamed file header and provide statement - Updated package version to remove "-proxy-core" suffix - Renamed all internal variables and functions to use "acp--" prefix - Added acp-open-log-file function for debugging - Improved log file naming with timestamps - Enhanced object normalization for better compatibility
Add comprehensive transcript functionality with automatic Git ignore support. Transcripts are now written by the ACP proxy to `.agent-shell/transcripts/` directory with improved formatting for tool calls, user prompts, and agent responses. Headers are automatically indented and tool call output is properly formatted with markdown code blocks.
Remove complex shared agent registry system in favor of using proxy config files directly. This simplifies the codebase by eliminating agent spec management and config file generation logic. - Remove shared agent registry variables and functions - Add acp-proxy-config-file customization option - Simplify proxy startup to use explicit config files - Remove agent registration and validation logic - Add more detailed logging for requests and notifications
- Remove derived agent names and require explicit agent-name parameter - Support dynamic agent creation via connectAgent request parameters - Cache connected agents to avoid duplicate connections - Fix indentation inconsistencies in defcustom and function definitions - Add agent identifier resolution in agent-shell for proper naming
Implement client registration and session-aware message routing for the shared proxy to handle multiple agent-shell buffers correctly. Add debug logging for session routing diagnostics and ensure notifications and requests are dispatched to the appropriate client based on session ID matching.
Remove the unused :subscribed field from the agent state and replace it with a more precise check for whether event handlers are properly initialized on the ACP client.
Remove agent-shell-debug-session-routing custom variable and all associated debug logging calls for session routing diagnostics to simplify the codebase.
Remove the conditional logic that checked for acp-proxy-handles-transcripts and always set the transcript file path directly.
Update package requirements to depend on external `acp` package instead of bundled `acp.el` core, aligning with agentclientprotocol.com spec.
Remove the session ID matching and buffer forwarding logic from the notification handler. This simplifies the notification processing by removing cross-buffer session management.
Refactor agent connection logic to support asynchronous operations: - Add connection state tracking (disconnected/connecting/connected/failed) - Implement connection waiter queue for concurrent requests - Replace synchronous ensure-connected with async variant - Normalize environment variables using symbols instead of strings - Update request/notification senders to handle async connections
Replace manual `AgentClient`/`ClientDelegate` with the new `agent-client-protocol` builder pattern (`AcpAgent`, `Responder`, `ConnectionTo`). Removes `delegate.rs` and rewrites agent spawning, notification handling, and permission responses to use the updated schema types. Adds `acp/agentExtNotification` forwarding for rate-limit and other extension notifications.
Introduce `acp/agentStderr` notification to stream filtered stderr output from agents to clients. Only lines containing "ERROR" or "WARN" are forwarded, with ANSI codes stripped. Also adds RFC 3339 timestamps to file-based tracing output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to agent-shell!
Checklist
M-x checkdocandM-x byte-compile-file.