Add actionable algebraic-loop diagnostics - #168
Merged
Conversation
5 tasks
jamestjsp
force-pushed
the
codex/algebraic-loop-diagnostics
branch
from
July 31, 2026 19:51
774a460 to
a7e05e8
Compare
jamestjsp
marked this pull request as ready for review
July 31, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167.
What changed
AlgebraicLoopErrorwith implicated named channels and the actual feedthrough-equation condition numbererrors.Is(err, ErrAlgebraicLoop)and supporterrors.AsthroughConnect,ConnectByName, LFT, Feedback, and zero-delay approximation failuresFeedbackdelay path from PR Fold SafeFeedback into Feedback delay options #166Semantics
Conditionis the condition number, not a reciprocal estimate. Exact singularity reports+Inf; numerically rejected but nonsingular equations report a large finite value. The previously suggested scalar gain0.999is not near-singular under this relative condition metric, so the regression uses a genuinely ill-conditioned MIMO feedthrough equation.Operations without signal metadata return the typed condition diagnostic with an empty
Signalsslice. The structuralDiscretizeWithOptsrejection remains the sentinel fallback because it does not factor a feedthrough equation and therefore has no honest condition estimate.Validation
go fix ./...go vet ./...go test -v -count=1go test -race -count=1 ./...Feedback, approximated-delay feedback,ZeroDelayApprox, andConnect; allocations are unchangedRebase
Rebased onto the current
mainafter PR #166. The renamed conflict site retains this PRs%wwrapping and algebraic-loop diagnostic behavior.