Improve Lyapunov benchmark performance reporting - #17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 651278524f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| lines.append("| Routine | Dataset | N | C11 (μs) | F77 (μs) | F77/C11 Ratio | Delta (μs) |") | ||
| lines.append("|---------|---------|---|----------|----------|---------------|------------|") | ||
| for c in fortran_faster: | ||
| ratio = c.c_mean_us / c.f_mean_us if c.f_mean_us > 0 else float("inf") |
There was a problem hiding this comment.
Fix inverted ratio reported as F77/C11
The new Fortran Faster Rows table labels the column as F77/C11 Ratio, but the value is computed as c_mean_us / f_mean_us (C11/F77). This inverts the meaning of every reported ratio and can mislead performance decisions (for example, C11=40 and F77=20 is shown as 2.00x even though F77/C11 is 0.50x). Please either compute f_mean_us / c_mean_us or relabel the column to match the current formula.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1594fe1 by relabeling the column to F77 Advantage, matching the existing C11-time / F77-time formula and sort order. The focused report-rendering test was updated and passes.
Summary
Validation
Final generated report showed no BB03AD/BB04AD row more than 1.5x slower than Fortran; remaining Fortran-faster rows were BB04AD ex4.4 at 1.11x, 1.07x, and 1.06x.