Skip to content

Global log runtime verbosity - #1

Open
rod007vrr wants to merge 5 commits into
masterfrom
salvation
Open

Global log runtime verbosity#1
rod007vrr wants to merge 5 commits into
masterfrom
salvation

Conversation

@rod007vrr

@rod007vrr rod007vrr commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

created runtime verbose log

@narensrini

narensrini commented Jul 20, 2022

Copy link
Copy Markdown
Collaborator

For bin/exec.mli, can we have a comment in the file saying that the interface is empty because exec.ml is an executable? It's usually a good practice to do this.

narensrini
narensrini reviewed Jul 20, 2022
View reviewed changes
Comment thread async_dynamic_log/.ocamlformat Outdated
Comment thread async_dynamic_log/bin/testing.ml Outdated
Comment thread async_dynamic_log/bin/testing.ml Outdated
Comment thread async_dynamic_log/src/foo.ml Outdated
Comment thread async_dynamic_log/src/foo.mli Outdated
Comment thread async_dynamic_log/src/log_dynamic.ml Outdated
Comment thread async_dynamic_log/src/log_dynamic.mli
narensrini
narensrini reviewed Jul 29, 2022
View reviewed changes
Comment thread async_dynamic_log/.ocamlformat Outdated
Comment thread async_dynamic_log/bin/lit.txt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@narensrini narensrini narensrini left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rod007vrr @narensrini