Skip to content

qtgui: expose Reset for ordinary Color sliders - #386

Merged
janhubicka merged 1 commit into
mainfrom
agent/qtgui-color-default-reset
Sep 24, 2026
Merged

janhubicka merged 1 commit into
mainfrom
agent/qtgui-color-default-reset

Conversation

@janhubicka

Copy link
Copy Markdown
Owner

Summary

Continue the Phase C default/modified-state rollout with the straightforward numeric controls in Color.

  • Opt these saved sliders into the existing real-default / modified / Reset presentation:
    • Black
    • Presaturation
    • White balance R/G/B
    • Backlight intensity
    • Backlight temperature
  • Reset values come from a fresh ParameterState, so there is no duplicate default table.
  • Reset remains a separate undoable gesture and is only shown when the current value differs from its real default.
  • Leave dye models, gamut/chart presentation, neutral-area/auto-level operations, observer/custom-whitepoint widgets, and tone-curve editors unchanged because their semantics are not simple numeric-slider resets.
  • Extend workspace churn to require default/reset metadata for all seven migrated color.* keys.

No color algorithm, calibration policy, .par format, or existing parameter default changes.

This PR is independent of the section-folding PRs rather than stacked on them.

[ci:ubuntu-checking]

Continue the Phase C default/modified-state rollout with the Color controls whose
semantics are plain numeric document parameters.

Opt Black, Presaturation, process-space RGB white balance, Backlight intensity,
and Backlight temperature into ParameterPanel's real-default presentation. Reset
targets come from a fresh ParameterState, remain separate undo gestures, and are
shown only while the corresponding saved value differs from its actual default.

Deliberately leave dye models, gamut/chart presentation, neutral-area/auto-level
operations, observer/custom-whitepoint widgets, and tone-curve editors unchanged;
those have calibration or custom-editor semantics that should not be forced into
the numeric slider convention.

Extend workspace churn to require default/reset metadata for all seven migrated
Color keys.
@janhubicka
janhubicka marked this pull request as ready for review September 24, 2026 11:13
@janhubicka
janhubicka merged commit 5f5c56d into main Sep 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant