qtgui: expose Reset for Image Layer mix sliders - #387
Draft
janhubicka wants to merge 1 commit into
Draft
janhubicka wants to merge 1 commit into
janhubicka wants to merge 1 commit into
Conversation
Continue the Phase C default/modified-state rollout with the six saved RGB mix parameters in Image Layer. Opt the three dark-offset channels and three RGB mixture weights into ParameterPanel's real-default presentation. Reset targets are taken from a fresh ParameterState, appear only when the saved value differs from that default, and remain separate undoable gestures. Keep the source-choice checkbox and Set by dark/neutral/infrared controls unchanged: the former is a discrete mode and the latter are one-shot operations, not numeric slider state. Extend workspace churn so every image_layer mix key must expose both its keyed spin box and default/reset metadata.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the Phase C default/modified-state rollout with the six numeric mix controls in Image Layer.
ParameterState, so defaults are not duplicated in the GUI.image_layer.*numeric key must expose both its keyed spin box and default/reset metadata.No image-layer algorithm, automatic calibration operation, .par format, or default value changes.
This PR is independent of the other Phase C PRs rather than stacked on them.
[ci:ubuntu-checking]