qtgui: expose Reset for Screen reconstruction sliders - #388
Draft
janhubicka wants to merge 1 commit into
Draft
janhubicka wants to merge 1 commit into
janhubicka wants to merge 1 commit into
Conversation
Continue the Phase C default/modified-state rollout with the Screen controls whose semantics are ordinary numeric document parameters. Opt Collection threshold and the ten numeric pre/post-demosaic denoising parameters into ParameterPanel's real-default presentation. Keep Screen type, collection quality, demosaicing/scaling modes, and denoise mode enums unchanged, and retain the existing Reset behavior for adjustable red/green strip widths. Reset targets come from a fresh ParameterState, are shown only for modified values, and remain separate undoable gestures. Extend workspace churn to require default/reset metadata for all thirteen numeric Screen controls that now use the convention.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the Phase C default/modified-state rollout with the ordinary numeric controls in Screen.
ParameterStateand remain separate undoable gestures.No reconstruction algorithm, denoise behavior, .par format, or default values change.
This PR is independent of the other Phase C PRs rather than stacked on them.
[ci:ubuntu-checking]