qtgui: expose Reset for Geometry numeric controls - #389
Draft
janhubicka wants to merge 1 commit into
Draft
janhubicka wants to merge 1 commit into
janhubicka wants to merge 1 commit into
Conversation
Finish the small safe Geometry portion of the Phase C default/modified-state rollout. Opt Lens center distance and Final rotation into ParameterPanel's real-default presentation. Lens center distance retains its explicit 0 = Auto special value, which is also the real ParameterState default; Final rotation resets to the fresh-state orientation default. Both remain separate undoable reset gestures. Do not add Reset to scanner geometry enums, fit-request toggles, nonlinear session state, or fitted lens/tilt results; those are discrete/calibration semantics already handled by their dedicated controls. Extend workspace churn to require default/reset metadata for both migrated Geometry keys.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish the small safe Geometry portion of the Phase C default/modified-state rollout.
0 = Autofor Lens center distance; it is also the realParameterStatedefault.No geometry solver behavior, fitted calibration result, .par format, or parameter default changes.
This PR is independent of the other Phase C PRs rather than stacked on them.
[ci:ubuntu-checking]