Add ignore_empty Parameter to has_changed Method#621
Open
Mng-dev-ai wants to merge 1 commit intojazzband:masterfrom
Open
Add ignore_empty Parameter to has_changed Method#621Mng-dev-ai wants to merge 1 commit intojazzband:masterfrom
Mng-dev-ai wants to merge 1 commit intojazzband:masterfrom
Conversation
dff2f18 to
73d3395
Compare
Contributor
|
Can you describe a use-case where To me this sounds a little as https://docs.astral.sh/ruff/rules/django-nullable-model-string-field/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
has_changedmethod returns True if the value changes from null to "" and vice versa, which is often not what we wantSolution
Added
ignore_emptyparameter with default value to True to ignore if value changed from null to "" and vice versaTests
I will add tests if you agree on the idea of this pr