Move verbose_name and verbose_name_plural from TaggedItem to ItemBase#938
Open
Esmat434 wants to merge 1 commit intojazzband:masterfrom
Open
Move verbose_name and verbose_name_plural from TaggedItem to ItemBase#938Esmat434 wants to merge 1 commit intojazzband:masterfrom
Esmat434 wants to merge 1 commit intojazzband:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #158.
It moves the verbose_name and verbose_name_plural attributes from TaggedItem to ItemBase.
All classes inheriting from ItemBase (including GenericTaggedItemBase and TaggedItemBase) will now automatically have these attributes.
This avoids the need for developers to redefine them in custom subclasses, solving the reported issue.
No change in existing behavior for TaggedItem itself, since the default values remain the same.