Skip to content

chore(mypy): drop vestigial tornado ignore_missing_imports override - #676

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/chore/mypy-strictness/drop-vestigial-tornado-ignore-missing-imports--1939167c
Aug 5, 2026
Merged

chore(mypy): drop vestigial tornado ignore_missing_imports override#676
mergify[bot] merged 1 commit into
mainfrom
devs/jd/chore/mypy-strictness/drop-vestigial-tornado-ignore-missing-imports--1939167c

Conversation

@jd

@jd jd commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Tornado ships a py.typed marker, so its types resolve without help.
The override was silently downgrading every tornado symbol to Any if
the package ever went missing, instead of failing loudly.

mypy still reports no issues with the override removed.

Tornado ships a `py.typed` marker, so its types resolve without help.
The override was silently downgrading every tornado symbol to `Any` if
the package ever went missing, instead of failing loudly.

`mypy` still reports no issues with the override removed.

Change-Id: I1939167c4dd59eb99ca1d71a18307af6db0f5e2d
@jd

jd commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 chore(mypy): drop vestigial tornado ignore_missing_imports override #676 👈
2 fix: annotate wait_base.radd as taking the int seed from sum() #677
3 chore(mypy): enable the strictness options strict leaves off #678
4 refactor: drop always-true truthiness checks and enable truthy-bool #679
5 refactor: declare BaseAction's REPR_FIELDS and NAME as ClassVar #680
6 test: fix possibly-undefined and deprecated call sites #681
7 refactor: mark overridden methods with @OverRide #682

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-08-05 15:24 UTC · Rule: default · triggered by rule autoqueue
  • Checks skipped · PR is already up-to-date
  • Merged2026-08-05 15:24 UTC · at bc8baca3b8b0f2a0a579c5614f86ac4e880e8ade · squash

This pull request spent 8 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify
mergify Bot merged commit 656e960 into main Aug 5, 2026
9 checks passed
@mergify
mergify Bot deleted the devs/jd/chore/mypy-strictness/drop-vestigial-tornado-ignore-missing-imports--1939167c branch August 5, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant