chore(mypy): drop vestigial tornado ignore_missing_imports override - #676
Merged
mergify[bot] merged 1 commit intoAug 5, 2026
Conversation
Tornado ships a `py.typed` marker, so its types resolve without help. The override was silently downgrading every tornado symbol to `Any` if the package ever went missing, instead of failing loudly. `mypy` still reports no issues with the override removed. Change-Id: I1939167c4dd59eb99ca1d71a18307af6db0f5e2d
Owner
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Aug 5, 2026
jd
marked this pull request as ready for review
August 5, 2026 15:24
Contributor
Merge Queue Status
This pull request spent 8 seconds in the queue, including 1 second running CI. Required conditions to merge
|
mergify
Bot
deleted the
devs/jd/chore/mypy-strictness/drop-vestigial-tornado-ignore-missing-imports--1939167c
branch
August 5, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tornado ships a
py.typedmarker, so its types resolve without help.The override was silently downgrading every tornado symbol to
Anyifthe package ever went missing, instead of failing loudly.
mypystill reports no issues with the override removed.