Skip to content

ci: run on pull requests targeting any base branch - #683

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/chore/mypy-strictness/run-pull-reqs-targeting-base-branch--1c211a10
Aug 5, 2026
Merged

ci: run on pull requests targeting any base branch#683
mergify[bot] merged 1 commit into
mainfrom
devs/jd/chore/mypy-strictness/run-pull-reqs-targeting-base-branch--1c211a10

Conversation

@jd

@jd jd commented Aug 5, 2026

Copy link
Copy Markdown
Owner

on.pull_request.branches filters on the base branch, not the head. With
it pinned to main, only a pull request merging directly into main ran
CI -- every stacked pull request, whose base is the branch below it in the
stack, got no test, lint or mypy run at all and showed nothing but the
Mergify checks.

Drop the filter so CI runs for every pull request regardless of base.

`on.pull_request.branches` filters on the *base* branch, not the head. With
it pinned to `main`, only a pull request merging directly into `main` ran
CI -- every stacked pull request, whose base is the branch below it in the
stack, got no test, lint or mypy run at all and showed nothing but the
Mergify checks.

Drop the filter so CI runs for every pull request regardless of base.

Change-Id: I1c211a106a57b9f4986bec4b76c0680c1a0f1b61
@jd

jd commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 ci: run on pull requests targeting any base branch #683 👈
2 fix: annotate wait_base.radd as taking the int seed from sum() #677
3 chore(mypy): enable the strictness options strict leaves off #678
4 refactor: drop always-true truthiness checks and enable truthy-bool #679
5 refactor: declare BaseAction's REPR_FIELDS and NAME as ClassVar #680
6 test: fix possibly-undefined and deprecated call sites #681
7 refactor: mark overridden methods with @OverRide #682

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-08-05 15:41 UTC · Rule: default · triggered by rule autoqueue
  • Checks skipped · PR is already up-to-date
  • Merged2026-08-05 15:41 UTC · at f2df8d0aae136f150b098670cf9e6eec0f1d38b6 · squash

This pull request spent 8 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Aug 5, 2026
@mergify
mergify Bot merged commit 4299cdf into main Aug 5, 2026
9 checks passed
@mergify
mergify Bot deleted the devs/jd/chore/mypy-strictness/run-pull-reqs-targeting-base-branch--1c211a10 branch August 5, 2026 15:41
@mergify mergify Bot removed the queued label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant