feat(site): deploy demo build to GitHub Pages - #28
Merged
Merged
Conversation
Vite base and router basename follow VITE_BASE so the bundle serves from /enspack/; build writes 404.html and .nojekyll because Pages has no rewrites. Workflow publishes on pushes to master touching apps/site. Co-authored-by: Jeff Lau <jefflau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Publishes the WP-19 catalog site to GitHub Pages so it can be seen before
enspack.devexists: https://jefflau.github.io/enspack/..github/workflows/pages.yml: on push tomastertouchingapps/site/**(orworkflow_dispatch), builds@enspack/sitewithVITE_BASE=/enspack/,VITE_DATA_SOURCE=demo,VITE_CHAIN=sepoliaand deploys viaactions/deploy-pages. Demo fixtures until the Sepolia indexer is publicly reachable; flipVITE_DATA_SOURCEand setVITE_INDEX_URLthen.vite.config.tsreadsVITE_BASE;main.tsxsets the routerbasenamefromimport.meta.env.BASE_URL(routerBasename, unit-tested) so deep links work under the sub-path.pnpm buildnow also writesdist/404.html(copy ofindex.html) anddist/.nojekyll, because Pages has no rewrite rules.Verification
pnpm --filter @enspack/site typecheck|test(32 tests) and biome clean.VITE_BASE=/enspack/served withvite preview: deep link/enspack/name/qwen--…renders the model page, wordmark returns to/enspack/, row click navigates under/enspack/name/….Model page served under /enspack/ sub-path
After merge
The workflow calls
actions/configure-pageswithenablement: true. If the first run fails on enablement, set Settings → Pages → Source to "GitHub Actions" once and re-run.To show artifacts inline, enable in settings.