fix: pin ENSv2 defaults to one Sepolia deployment's UniversalResolverV2; accept keys without 0x - #29
Merged
Merged
Conversation
…'s UniversalResolverV2; accept private keys with or without 0x Co-authored-by: Jeff Lau <jefflau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live publish attempt failed because ENS repointed the public
UpgradableUniversalResolverProxy(0xeEeE…EeEe) to a brand-new Sepolia deployment between 14:55 and 12:40 UTC:ROOT_REGISTRY()moved from0x8115…4354to0x0F62…4A55, soenspack.eth, its UserRegistry/resolver andmirrors.enspack.eth(all registered on the previous stack, still intact) became invisible to discovery, and the fork tests' impersonated ETHRegistrar lost its role.ensV2ConfigFordefaultuniversalResolveris now the previous deployment's ownUniversalResolverV20x4a1817d13e9cf196f471725176355c1234b63c70, which keeps discovery, the four implementation/registrar defaults and everything already registered mutually consistent.ENSPACK_ENSV2_UNIVERSAL_RESOLVER=0xeEeE…EeEefollows ENS again; all five overrides should move together when adopting a new deployment. Documented indocs/ens-v2.mdand the CLI README.ENSPACK_PUBLISHER_KEY/ENSPACK_OPERATOR_KEY) and registrar accept private keys with or without the0xprefix (secret stores strip it); bootstrap already did. Values are never logged.Proof: root
pnpm checkgreen, including every Sepolia-fork suite against the pinned deployment (core resolver-v2 6, publisher-v2 10, ens-setup 5; registrar-v2 2; e2e sepolia-fork 5). Live check:UniversalResolverV2(0x4a18…).findOwner(mirrors.enspack.eth)→ the hot key,findResolver→0xAf71…9520.