Add support for creating child tokens for token credential binding#338
Add support for creating child tokens for token credential binding#338bluesliverx wants to merge 3 commits intojenkinsci:masterfrom
Conversation
bluesliverx
changed the title
bluesliverx
changed the title
| } | ||
|
|
||
| protected static List<String> generatePolicies(String policies, EnvVars envVars) { | ||
| public static List<String> generatePolicies(String policies, EnvVars envVars) { |
There was a problem hiding this comment.
Necessary to use this method in the vault token credential binding code.
| } | ||
| } | ||
|
|
||
| final class VaultAuthorizationResult { |
There was a problem hiding this comment.
This class was needed to return the actual token from authorizeWithVault instead of requiring another call to Vault to lookup the token after the fact (since it is unretrievable from a configured Vault class instance).
|
Cancel that, I found at least one issue in our prod environment, looking into it now. |
|
@jetersen this is ready for review now. We've been using this in our prod environment for at least a week now and it has been very stable (and has correctly limited access when child tokens are enabled). |
|
@jetersen any chance I can get a review here? |
|
@jenkinsci/hashicorp-vault-plugin-developers Could I get a review possibly? This has been sitting for a couple of months. We've been using it in production with no issues. |
|
Hi @bluesliverx, this plugin doesn't seem to be actively maintained. You can adopt it following the instructions here: https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/ |
2 participants
Fixes #339