Slight tweak#1
Open
kingkool68 wants to merge 1 commit into
Open
Conversation
You don'y need the getQuote() function since it can be reduced to one line and you only use it once. Good thinking on cahcing the jQuery selector by storing the next button as it's own variable but if you don't use that cached selector again then it doesn't really matter.
Another fun technique is to bind an event to an element and then you want to trigger that event so you could write `$('.next').on('click', randomize).trigger('click')` which tells jQuery to basically simulate a click on the next button triggering your `randomize()` function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You don'y need the getQuote() function since it can be reduced to one line and you only use it once. Good thinking on cahcing the jQuery selector by storing the next button as it's own variable but if you don't use that cached selector again then it doesn't really matter.
Another fun technique is to bind an event to an element and then you want to trigger that event so you could write
$('.next').on('click', randomize).trigger('click')which tells jQuery to basically simulate a click on the next button triggering yourrandomize()function.