Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
Vernier::Output::FileListingto be initialized with a custom relevant files filter by filename, so that the files to included in the display can be customized.A few things that the filter does not handle right now -
The relevant files filter current only considers the file name, and does not allow the sample threshold to be customized, because the total on
Output::FileListingaccessible afterOutput::FileListingis initialized. It may make sense to addtotalto the profile/result. There is already atotal_bytesonVernier::Result, but looks like there is a todo to remove it. Can we keep it? Can we move the entire concept of "total" from an output to the profile/result?When we parse
samples_by_file, the file names from a live profile are changed by theFilenameFilter. When we display, we need to open the files to read the lines, which may not exist under the changed file name. Should we allow FilenameFilter to also be overridden? Would we have both a relevant file names filter + a file name filter?