fix: run event hooks as direct argv instead of through sh - #9
Merged
Conversation
jhochenbaum
force-pushed
the
manifest-portable-commands
branch
from
August 19, 2026 02:49
eb6c532 to
34556ad
Compare
Herdr 0.8 runs event hooks from the plugin root, so event.js resolves without sh or HERDR_PLUGIN_ROOT expansion. Pane commands keep their wrapper because their cwd is the reviewed worktree.
jhochenbaum
force-pushed
the
manifest-portable-commands
branch
from
August 19, 2026 02:51
34556ad to
07bcfc3
Compare
jhochenbaum
marked this pull request as ready for review
August 19, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unnecessary POSIX shell wrapper from event hooks.
Herdr 0.8 runs event commands from the plugin root, so
dist/bin/event.jsresolves directly as["node", "dist/bin/event.js"]. Pane commands keep their wrapper becauseplugin pane open --cwdruns them from the reviewed worktree.This removes one Windows incompatibility without changing pane behavior. Full Windows support remains in #10.
Validation: