A-MoreTesting: cover Deadline, Event, Echo, Storage - #9
Merged
Merged
Conversation
Deadline, Event, TaskType, and Echo's entire dispatch switch had zero tests, and Storage/TaskList only covered archive()/clearAll(), leaving load(), save(), corrupted-line handling, and basic add/get/remove/size untested. Add DeadlineTest, EventTest, TaskTypeTest, and EchoTest (the last driven through Echo#getResponse() so the dispatch logic can be tested without console I/O: one case per command, the unrecognized- command path, and the bye shortcut). Extend StorageTest with a save-then-load round trip, a corrupted-line-skip case, and a missing-file/folder case, and TaskListTest with add/get/remove/size. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
EchoTest's expected strings were written against Echo's original console wording. Merging branch-A-Personality changed that wording (e.g. "Got it." -> "Echoed!", the unknown-command message, the goodbye message), which left several assertions comparing against now-stale text rather than a real behavior regression. Update each assertion to match the current, correct wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DeadlineTest, EventTest, TaskTypeTest, EchoTest, and extends
StorageTest/TaskListTest for previously-untested behavior.
Includes a follow-up fix updating EchoTest's expected strings to
match branch-A-Personality's wording changes, discovered while
merging master into this branch.
See commit messages for details.