Fix: Prevent NameError in finally block - #1
Open
levis-suse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if requests.get() raises a connection-level exception (such as a ConnectionError or Timeout), the response variable is never assigned.
Because the finally block executes before sys.exit(1) can unwind the stack, attempting to log response.status_code triggers a NameError: name 'response' is not defined.
Proposed fix:
Initialized response = None before the try blocks in both the get_products and search_package functions.
Added an if response is not None: inside the finally blocks to make sure the status code is only logged if the HTTP request successfully returned a response object.
Network failures should now exit cleanly.