jmix-style-ui: say that a theme token cannot reach a canvas-painting component - #27
Open
knstvk wants to merge 2 commits into
Open
jmix-style-ui: say that a theme token cannot reach a canvas-painting component#27knstvk wants to merge 2 commits into
knstvk wants to merge 2 commits into
Conversation
knstvk
marked this pull request as ready for review
August 4, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25.
Drafted from a field report while the problem was fresh, by the agent that hit it. It is unreviewed: treat the wording as a starting point, not a proposal to merge as-is.
Change
Adds a "When the component paints to a canvas" section after the existing "Why a wrong token is invisible to every gate", with a table separating CSS targets from drawing-API targets, a one-liner for checking whether an add-on's frontend module resolves CSS at all, and the three workable options for the canvas case. Adds a matching caveat to "Verify — the COMPUTED style, in a browser" (that check has nothing to read when the value never becomes a CSS declaration) and one bullet to "Forbidden".