chore: retire the Electron-side subtitle script#25
Merged
Conversation
extract-subtitles.mjs + the generate-subtitles IPC were dev-only (the script was never packaged, needed a system node and a dev node_modules tree) and lost their last advantage once the in-app caption pipeline gained whisper-small, forced language, and styled-subtitle output. - remove scripts/extract-subtitles.mjs, the generate-subtitles handler, preload method, and type declaration - sidebar Auto-Generate now opens the auto-captions dialog preset to styled-subtitle output; its busy state follows isAutoCaptioning - drop the wavefile dependency (script-only) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-app caption pipeline now covers everything the dev-only Electron script did (whisper-small #22, styled subtitles #23, timeline lane, click-to-edit), so the script retires.
scripts/extract-subtitles.mjs,generate-subtitlesIPC handler, preload method, and d.ts declaration removed (script was never packaged — required system node + dev node_modules; see the packaged-app discussion that started this arc).isAutoCaptioning.wavefiledependency dropped (script-only).@xenova/transformersstays — the in-app worker uses it.tsc 0 errors · biome clean · vitest 229/229 · i18n 12 locales · build OK
🤖 Generated with Claude Code