refactor(ui): replace remaining inline icons with the shared icon module - #276
Open
truongthinh1412 wants to merge 3 commits into
Open
truongthinh1412 wants to merge 3 commits into
truongthinh1412 wants to merge 3 commits into
Conversation
truongthinh1412
force-pushed
the
refactor/208-shared-icon-module
branch
from
September 15, 2026 17:52
0407725 to
ca0a48b
Compare
Author
|
Rebased onto current What the rebase involved, in case it's useful context:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the shared icon module migration requested in #208 (tranche 1: #220 created
src/components/icons.tsxwith 11 icons; #265 migrated one more glyph).StrokeSvgIconbase for stroke-drawn glyphs (per-glyphstroke-width,viewBox, round caps/joins) plus 47 new components copied from the real pasted paths (22 fill, 25 stroke).<svg>icon blocks across 33 non-test source files, preserving each call site's size, class, style, reactivity, and accessibility semantics — zero intended visual change.MergeReadinessPanel, 3 standalone × close glyphs) withCheckIcon/CloseIconat size 12.src/documents/DocumentIcon.tsxinto the shared module; importers updated with explicit sizes matching its previous defaults (14/12/18/18).src/components/icons.client.test.tsxrendering all 59 exports: default size 16, custom size,currentColorinheritance, aria-hidden/<title>behavior.knip(lint:dead) stays green;depcruisereports no violations.Deliberately deferred (happy to follow up in this PR if preferred):
▶disclosure glyph inConnectPhoneModal— no byte-faithful filled-triangle component exists in the module; substituting a visibly different glyph would change rendering.src/lib/mermaid-lightbox.ts— plain.tsbuilding HTML strings, outside the module's.tsxscope.If one 39-file PR is too large, I'm happy to split it into smaller tranches on request.
Issues Resolved
Fixes #208
Check List