[7.0] Remove setDbo() and __get() from BaseDatabaseModel#47441
Open
Hackwar wants to merge 4 commits intojoomla:7.0-devfrom
Open
[7.0] Remove setDbo() and __get() from BaseDatabaseModel#47441Hackwar wants to merge 4 commits intojoomla:7.0-devfrom
Hackwar wants to merge 4 commits intojoomla:7.0-devfrom
Conversation
HLeithner
added
the
b/c break
laoneo
reviewed
Apr 23, 2026
|
|
||
| // @todo Moves queries out of the controller. | ||
| $db = $model->getDbo(); | ||
| $db = Factory::getDbo(); |
Member
There was a problem hiding this comment.
Better to move the whole logic with database access to the model.
Member
Author
There was a problem hiding this comment.
Yes, but that is a bit outside of the scope of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This removes the deprecated methods
setDbo()and__get()from theBaseDatabaseModeland all usages ofgetDbo()from the CMS. Especially in the updater we can remove the checks, since we can't update from 4.x to 7.0 without first going through 5.4 and 6.4.Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org: Removal of setDbo()/_db Manual#618
No documentation changes for manual.joomla.org needed