Fix punktum app module: UTF-8 encoding and stray dot in import#7
Open
serrebidev wants to merge 1 commit into
Open
Fix punktum app module: UTF-8 encoding and stray dot in import#7serrebidev wants to merge 1 commit into
serrebidev wants to merge 1 commit into
Conversation
punktum.py was committed as ISO-8859-1, so Python 3 (which requires UTF-8 source by default) fails to decode the umlauts in the header comment and the whole app module refuses to load. The import statement also had a stray trailing dot (import appModuleHandler.), which is a SyntaxError on its own. Re-encode the file as UTF-8 and drop the trailing dot; no functional changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Summary
The new
addon/appModules/punktum.pycurrently cannot load at all, for two independent reasons:Unterstützung für "Punktum") make the module fail to decode with aSyntaxError: (unicode error)before any code runs.import appModuleHandler.— the trailing dot is aSyntaxErrorby itself.This PR re-encodes the file as UTF-8 and removes the stray dot. No functional changes.
Validation
python -m py_compile addon/appModules/punktum.pyfails onmainand passes with this change (Python 3.13, matching NVDA 2026.x). Also running the fixed module in my installed NVDA copy.🤖 Generated with Claude Code
@