This repository was archived by the owner on Jul 5, 2021. It is now read-only.
Remove dependency on a package.json#16
Open
Galkon wants to merge 1 commit into
Open
Conversation
Removing dependency on package.json file existing just to initialize the `debug` instances allows this package to be bundled in production applications, such as electron applications, without requiring this module to be excluded from the bundling process. Considering this package name will very likely _never_ change, there is no reason not to hardcode the string so this package can be bundled properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing dependency on package.json file existing just to initialize the
debuginstances allows this package to be bundled in production applications, such as electron applications, without requiring this module to be excluded from the bundling process. Considering this package name will very likely never change, I don't see a reason not to hardcode the string so this package can be bundled properly.