chore(tooling): fix import lint portability and untrack planning notes#81
Merged
Conversation
mapfile is a Bash 4+ builtin, but macOS ships Bash 3.2, so the import lint lane could exit before it linted anything. Collect paths with the same while-read loop already used by ci_classify_changes.sh.
.local/ is ignored; these two files were the only tracked exceptions left in it. Both are retained locally as *.done.md, so no content is lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated housekeeping changes, split into one commit each. No runtime impact.
Import lint portability
scripts/run_import_lint.shcollected its path array withmapfile, a Bash 4+builtin. macOS ships Bash 3.2 (
/bin/bashhere is 3.2.57), wheremapfiledoesnot exist; under
set -euo pipefailthe lane could exit before linting anything.Replaced with the
while IFS= read -rloop already used byscripts/ci_classify_changes.sh, so the two scripts now share one idiom.Untrack completed planning notes
.local/is ignored (.gitignore:28), but.local/issues.mdand.local/public-api-surface-improvements.mdwere tracked exceptions inside it.Both are finished and are retained locally as
*.done.md, so nothing is lost —this only stops tracking them.
Verification
make lint,make type, andmake testpass locally. The pre-push gate(
make prepush) passed.