Skip to content

fix: satisfy clippy 1.96 profile percentage lint #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsvana merged 1 commit into from
Jul 8, 2026
Merged

fix: satisfy clippy 1.96 profile percentage lint #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,10 @@ fn calculate_profile_match(current: &[StoredTrigger], profile: &[StoredTrigger])
(matched, profile.len())
}

fn profile_match_percentage(matched: usize, total: usize) -> usize {
(matched * 100).checked_div(total).unwrap_or(100)
}

/// Filter out permanent triggers from a list
#[allow(dead_code)]
fn filter_out_permanent(
Expand Down Expand Up @@ -1603,11 +1607,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
let profile = load_profile(profile_name).unwrap_or_default();
let (matched, total) =
calculate_profile_match(&current_non_permanent, &profile);
let percentage = if total > 0 {
(matched * 100) / total
} else {
100
};
let percentage = profile_match_percentage(matched, total);

let is_current = current_profile.as_ref() == Some(profile_name);
let marker = if is_current { "*" } else { " " };
Expand Down Expand Up @@ -1708,11 +1708,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
let profile = load_profile(profile_name).unwrap_or_default();
let (matched, total) =
calculate_profile_match(&current_non_permanent, &profile);
let percentage = if total > 0 {
(matched * 100) / total
} else {
100
};
let percentage = profile_match_percentage(matched, total);

let marker = if matched == total && total > 0 {
" <- best match"
Expand Down Expand Up @@ -2737,4 +2733,15 @@ mod tests {
assert_eq!(matched, 1);
assert_eq!(total, 2);
}

#[test]
fn test_profile_match_percentage() {
assert_eq!(profile_match_percentage(1, 2), 50);
assert_eq!(profile_match_percentage(2, 2), 100);
}

#[test]
fn test_profile_match_percentage_defaults_to_full_match_for_empty_profile() {
assert_eq!(profile_match_percentage(0, 0), 100);
}
}
Loading