Add onStop callback for animation completion and cancellation#1144
Open
manual-hue wants to merge 1 commit intojuliangarnier:devfrom
Open
Add onStop callback for animation completion and cancellation#1144manual-hue wants to merge 1 commit intojuliangarnier:devfrom
manual-hue wants to merge 1 commit intojuliangarnier:devfrom
Conversation
Implements feature request from issue juliangarnier#1044 to add a unified callback that fires when animations either complete naturally or are cancelled/ interrupted by other animations. Changes: - Add onStop callback to Timer class that is called when: * Animation completes naturally (called after onComplete) * Animation is cancelled/interrupted (called without onComplete) - Update type definitions to include onStop in all callback interfaces - Add onStop to default callbacks in globals - Update render logic to call onStop alongside onComplete - Maintain backward compatibility with all existing callbacks This allows developers to reliably track when animations end regardless of whether they complete or are interrupted, solving the use case of managing animation counters and CSS transitions. Fixes juliangarnier#1044
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements feature request from issue #1044 to add a unified callback that fires when animations either complete naturally or are cancelled/ interrupted by other animations.
Changes:
This allows developers to reliably track when animations end regardless of whether they complete or are interrupted, solving the use case of managing animation counters and CSS transitions.
Fixes #1044