Ask Kodi for game sources by the name it accepts - #92
Open
sunlollyking wants to merge 1 commit into
Open
sunlollyking wants to merge 1 commit into
sunlollyking wants to merge 1 commit into
Conversation
Files.GetSources takes "games", not "game". The singular was rejected by schema validation, so browsing Game Sources in the shortcut editor returned nothing and the entry could not be used. Kodi gained the enum entry in xbmc/xbmc#29066, which added "games" only -- matching the key the sources are stored under and the sources://games/ path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files.GetSourcesacceptsgames, notgame. The singular is rejected by schema validation, so browsing Game Sources in the shortcut editor returns nothing and a games menu item cannot be created.Kodi only gained a games entry in the
Files.Mediaenum recently, in xbmc/xbmc#29066, and that addedgamesalone — matching the key the sources are stored under insources.xmland thesources://games/path itself. The singular has never been accepted.Tested against a Kodi build carrying that change: with
gamethe call is refused, withgamesthe browser lists the configured game sources and a shortcut created from one resolves to a real path.Related: #89 stops the refusal taking the whole script down, but the group still comes up empty without this.