Skip to content

Modernize, TypeScript support, add tests#29

Open
Theaninova wants to merge 8 commits into
kaitai-io:masterfrom
Theaninova:modernize
Open

Modernize, TypeScript support, add tests#29
Theaninova wants to merge 8 commits into
kaitai-io:masterfrom
Theaninova:modernize

Conversation

@Theaninova

Copy link
Copy Markdown

This PR adds the following

  • Rewrite in TypeScript, the JS version was used as the base but I've done tons of code splitting and rewriting to make the code base more readable
  • Test coverage for the public API
  • Bundling
    • ESM version
    • CJS version
    • Browser bundle with & without Pako

This is meant to enhance kaitai-io/kaitai_struct_compiler#249

@danaragao

Copy link
Copy Markdown

This is very useful. Any chance that this could be evaluated and merged @generalmimon ?

@cleudopaiva

Copy link
Copy Markdown

Something like this would be amazing. @generalmimon

@generalmimon

Copy link
Copy Markdown
Member

@cleudojunior:

Something like this would be amazing.

Why? I actually consider this PR unnecessary at this point, because I've already merged #25, so the runtime library is already ported to TypeScript. As far as I can tell, this PR does the same but also adds quite a bit of seemingly unnecessary complexity and the resulting code structure significantly deviates from the structure used in other runtime libraries, which would complicate future maintenance.

So unless you point out to me what is useful about this PR, I'm in favor of closing it.

@cleudopaiva

Copy link
Copy Markdown

@cleudojunior:

Something like this would be amazing.

Why? I actually consider this PR unnecessary at this point, because I've already merged #25, so the runtime library is already ported to TypeScript. As far as I can tell, this PR does the same but also adds quite a bit of seemingly unnecessary complexity and the resulting code structure significantly deviates from the structure used in other runtime libraries, which would complicate future maintenance.

So unless you point out to me what is useful about this PR, I'm in favor of closing it.

That's great, I hadn't seen that that was already added. That was an old need in a system that I work on. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants