🎉 Remember settings window geometry - #1474
Open
fzlzjerry wants to merge 2 commits into
Open
Conversation
fzlzjerry
marked this pull request as ready for review
August 11, 2026 08:55
Contributor
|
Thank you very much! From a first glance, this looks very good. Hopefully I'll soon find the time to do a thorough review. On idea: Do you think it could be possible to also restore the width of the left and right sidebars? |
fzlzjerry
force-pushed
the
fix/1462-settings-window-bounds
branch
from
August 12, 2026 04:03
804331c to
bd4c4d1
Compare
Author
|
Yes — added in I also rebased the branch onto the latest |
fzlzjerry
force-pushed
the
fix/1462-settings-window-bounds
branch
from
August 13, 2026 13:05
bd4c4d1 to
0569b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This stores the settings window's normal bounds, maximized state, and left/right sidebar widths in a separate machine-local
settings-window-state.jsonfile. Restored window bounds are fitted to the best matching display's current work area, so removing a monitor or changing its resolution cannot leave the settings window off-screen. Missing or invalid state still uses the existing 1350 x 900 window and 370px sidebar defaults.Sidebar widths are loaded before the settings window is displayed, avoiding a flash of the default layout, and persisted when a resize finishes. Window bounds are saved both when the settings window closes normally and before Kando destroys it during application shutdown.
Focused tests cover state validation, persistence (including sidebar widths), multi-monitor coordinates, off-screen restoration, and oversized windows.
Testing
npm test(67 passing)npm run tschecknpm run lintnpm run prettierCloses #1462