independent-review: generalise internal project references - #73
Merged
Conversation
scripts/check_clean.sh failed the release: two files on public main named a private client project by repo name, and four places carried its internal MR numbers. The check is right — these are handoff artifacts read by strangers, and the repo is public regardless of what the zip excludes. SKILL.md ships in the zip besides. Generalised rather than deleted: the incidents are what make the round-cost rule persuasive, and a reader outside that project loses nothing when the two MRs become "two MRs on the same internal backend repo, of 8 and 7 rounds". The 7-round MR is referred to by its round count where the text needs to point back at it, so the narrative still hangs together. make smoke: OK (202 files, no internal artifacts). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release blocker for v0.20.
make smokefails:scripts/check_clean.shfound a private client project named by repo name in two files on publicmain, plus its internal MR numbers in four places.Not a false positive. These are handoff artifacts strangers read, the repo is public whatever the zip excludes, and
SKILL.mdships inside the zip anyway.Generalised rather than deleted — the incidents are what make the round-cost rule persuasive, and a reader outside that project loses nothing when two MRs become "two MRs on the same internal backend repo, of 8 and 7 rounds". Where the text needs to point back at one of them it now uses its round count, so the narrative still hangs together.
make smoke: OK — 202 files, all critical files present, no internal artifacts.🤖 Generated with Claude Code