fix(engine): retry passes rsync exit 23, a dangling symlink under -L - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every ctan sync since 2026-09-13 07:43 UTC fails at
listwith rsync exit 23: fourtugboat.cmnsymlinks undermacros/latex209/contrib/andobsolete/lost their target upstream between the 06:43 and 07:43 runs, and-Lreports each assymlink has no referent. The rest of the listing is intact (the 06:43 run had none of these lines and listed 512,375 objects), butretrypassed only 0 and 24, so the pipeline died six runs in a row.engines/rsync.yml:retrytreats 23 like 24. Forlistit is a dangling symlink skipped, and LIST_FLOOR is what catches a listing cut short. Forfetchit is a path that could not be read, which never lands in staging, somergedrops it from the state exactly as it does a vanished one. Forpreparea missing control file fails the next command. A comment onlistsays why 23 is passed there.examples/rsync: the offline check gainstask retry CMD='exit 23', which fails on main;render.txtchanges by the three renderings of the case line.retryrow.Storage and operations
None. No verb writes anything differently.
Test plan
rsync://rsync.dante.ctan.org/CTAN/macros/latex209/contrib/tugboat/:-rL --list-onlyprints the referent line, lists the two real files, exits 23;-rlists the link and exits 0examples/rsync:task run -- task offlinefails on main with the new line and passes here;task checkpasses aftertask render-updatev2.1.1, which rebuilds the images and movesv2; the next hourly ctan run is the live checktask render-updatein ctan and tlnet, three lines each