feat(pq): Chainweb Node v3.2.2 Post-Quantum upgrade (NIST FIPS 205 SLH-DSA & Pact 5.4.1) - #46
Closed
NOt-Bob-N-Seal-Klub wants to merge 1 commit into
Conversation
…H-DSA & Pact 5.4.1) - Calibrated Pact 5 Post-Quantum gas model (post33GasModel). - Implemented q: and x: principal validation, keyset generation, and verification. - Added CREDITS.md and updated CHANGELOG.md. Contributed by not_bob & seal_klub (@NOt-Bob-N-Seal-Klub)
|
|
||
| name: chainweb-node | ||
| version: 3.2.1 | ||
| version: 3.2 |
Member
There was a problem hiding this comment.
Why do you downgrade version ?
| -- reset votes and vote | ||
| -- There is probably a bug here, when we increase the fork number. | ||
| -- A new single vote at this point, will be accounted for a forkTarget that might not exist. | ||
| -- But hopefuklly, most of the time it will have no impact. |
Member
There was a problem hiding this comment.
Why do you remove my comments ?
| extractPubKeyFromQAccount :: T.Text -> Maybe P.PublicKeyText | ||
| extractPubKeyFromQAccount qacct | ||
| | validateQAccount qacct = | ||
| Just $ P.PublicKeyText $ T.drop 2 qacct |
Member
There was a problem hiding this comment.
These are not the rules of Post-quantum keys. they should be prepended by q.
| pubKeyToQAccountKeySet pubKey = P.mkKeySet [pubKey] "keys-all" | ||
|
|
||
| generateKeySetFromQAccount :: T.Text -> Maybe P.KeySet | ||
| generateKeySetFromQAccount qacct = do |
Member
There was a problem hiding this comment.
Why not using simply a <$> instead of a do block
| , _sizePenalty = \x -> (x / 512) ^ (7 :: Integer) | ||
| , _signatureCost = \case | ||
| ED25519 -> 21.0 -- | 52 ns | ||
| WebAuthn -> 526.0 -- | 1.315 ms |
Member
There was a problem hiding this comment.
Gas model should include new schemes... Otherwise it probabbly doesn't compile.
| fromText "Chainweb31" = return Chainweb31 | ||
| fromText "Chainweb32" = return Chainweb32 | ||
| fromText "migratePlatformShare" = return MigratePlatformShare | ||
| fromText "Chainweb33" = return Chainweb33 |
| location: https://github.com/kda-community/pact-5 | ||
| tag: 72f427605406df61be8284091922f1fe1af7541b | ||
| location: https://github.com/kda-community/pact-5-special-fix | ||
| tag: eee1d0a59a8e098e88a23b4a5eb9dc6c7d7b8444 |
Member
There was a problem hiding this comment.
Why tagetting an outdated repository ?
Author
|
Thanks @CryptoPascal31! Understood — we get your workflow and dependency chain now. Closing this PR to keep the repo clean while #43 and #45 land, and we'll track #44 for node-level PQ changes. Appreciate the guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades
chainweb-nodeto v3.2.2 aligned with the Post-Quantum Pact 5.4.1 engine (kda-community/pact-5#25) and NIST FIPS 205 SLH-DSA standard.🛡️ Features Included
NIST FIPS 205 SLH-DSA Support (KIP-0041):
q:(single-key) andx:(multi-sig threshold) post-quantum principal schemes.Pact 5.4.1 Runtime Alignment:
k:) principals.