Fix long option parsing by using expr instead of arithmetic expansion - #88
Closed
chenrui333 wants to merge 1 commit into
Closed
Fix long option parsing by using expr instead of arithmetic expansion#88chenrui333 wants to merge 1 commit into
chenrui333 wants to merge 1 commit into
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
changed the title
--version and --help on bash 3.2 by pre-parsing long flags
kdabir
self-requested a review
August 1, 2025 09:04
kdabir
approved these changes
Aug 1, 2025
kdabir
left a comment
kdabir
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix. I'll add tests in a separate commit so that this is covered for future.
kdabir
requested changes
Aug 1, 2025
kdabir
left a comment
kdabir
left a comment
Owner
There was a problem hiding this comment.
the current changes fail the shellcheck. I am fixing this in master directly and adding some tests. Thank you so much for contributing
Owner
|
Thanks for suggesting the fix. I could not merge your PR because it was failing shellcheck. However that prompted me to add tests for this and also fix it in a way that shellcheck doesn't complain. |
Owner
Author
|
yeah, that works for me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #87
relates to Homebrew/homebrew-core#231659