fix: deserialize JSON string body in HTTP provider before sending request#6548
Open
ausias-armesto wants to merge 5 commits into
Open
fix: deserialize JSON string body in HTTP provider before sending request#6548ausias-armesto wants to merge 5 commits into
ausias-armesto wants to merge 5 commits into
Conversation
dosubot
Bot
added
size:XS
dosubot
Bot
added
size:S
Contributor
Author
|
@shahargl Can you have a look at this pull request. It would be nice to have it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6547
When a workflow renders body: "{{ alert }}", the template produces a JSON string instead of a dict. Passing that string to requests.post(json=body) double-encodes it, sending a JSON string to the target instead of a JSON object.
The fix mirrors the existing handling already in place for headers: if body arrives as a string and is valid JSON, it is deserialized back to a dict before being handed to requests. Non-JSON strings are left unchanged for backwards compatibility.
Adds unit tests for the HTTP provider.