fix(swap): block backdrop clicks from closing swap dialog#201
Open
BitHighlander wants to merge 3 commits into
Open
fix(swap): block backdrop clicks from closing swap dialog#201BitHighlander wants to merge 3 commits into
BitHighlander wants to merge 3 commits into
Conversation
PR #186 added Hive to chains.ts with minFirmware 7.14.0 (wrong). The fix in ae70c35 (PR #187) was not carried through because develop already had the Hive entry — no conflict was surfaced during merge. - chains.ts: bump Hive minFirmware 7.14.0 → 7.16.0 (no released firmware supports Hive until 7.16.0) - CommandPalette: add firmwareVersion prop + filter with isChainSupported so ⌘K results also respect firmware gates - App.tsx: pass deviceState.firmwareVersion to CommandPalette
Trigger rebuildActivityHistory in the background (3s after ready) every time the state-change handler sees state='ready'. Covers both initial app startup and device reconnects. Passphrase wallets are skipped for privacy, matching the existing scanChainHistory guard.
Only the X button can now dismiss the swap dialog — prevents accidental closure mid-flow when clicking outside the modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onClick={handleClose}from the outer backdropBoxinSwapDialog.tsxTest plan